Difference between pages "Talk:ASH Errors" and "To coinmaster"

From Kolmafia
(Difference between pages)
Jump to navigation Jump to search
imported>PhilmASTErpLus
(Thanks for input, but does anyone know whether there exists other forms of code that can cause this error?)
 
imported>Bale
(r9555)
 
Line 1: Line 1:
Is this like were things like <font color="#ff7000">Script parsing error (X.ash, line Y)</font> are listed?--[[User:Icon315|Icon315]] 22:33, 14 April 2010 (UTC)
+
{{
 +
#vardefine:name|to_coinmaster}}{{
 +
#vardefine:return_type|coinmaster}}{{
  
:It's where they WILL be listed, once they are listed. --[[User:Bale|Bale]] 22:52, 14 April 2010 (UTC)
+
FunctionPage|
 +
name={{#var:name}}|
  
What Bale said. Also, I changed that to orange; I kept trying to click on it. :( --[[User:StDoodle|StDoodle (#1059825)]] 00:35, 15 April 2010 (UTC)
+
function1={{Function|
 +
name={{#var:name}}|
 +
aggregate={{#var:aggregate}}|
 +
return_type=boolean|
 +
return_also={{#var:return_also}}|
 +
parameter1={{Param|string|store}}|
 +
p1desc={{pspan|store}} is hopefully the name of a coinmaster|
 +
}}|
  
Also, if anyone's feeling particularly ambitious, https://kolmafia.svn.sourceforge.net/svnroot/kolmafia/src/net/sourceforge/kolmafia/textui/Parser.java should help. Just look for all the instances of parseException. (Speaking of which, would it be useful if these were presented in the order that they're checked?) --[[User:Heeheehee|Heeheehee]] 00:17, 17 April 2010 (UTC)
+
function_description=Returns the coinmaster that matches the string {{pspan|store}}. This is useful so that the coinmaster datatype can be used by other functions. If {{pspan|store}} does not match the name of any coinmaster, then the function returns $coinmaster[none]. This works on partial matches so that if {{pspan|store}} is "dime", this function will return $coinmaster[Dimemaster].|
  
I think alphabetical order would be better: this page is going to be excellent for first-time ASH scripters to understand what's wrong with their script. --[[User:Slyz|Slyz]] 10:41, 17 April 2010 (UTC)
+
code1={{CodeSample|
 +
title=Code Sample|
 +
description=This sells off all the Island War vendor trash to the appropriate coinmasters for quarters and dimes.|
 +
code=
 +
<syntaxhighlight>
 +
foreach trash in $items[red class ring, blue class ring, white class ring, PADL Phone,
 +
pink clay bead, purple clay bead, green clay bead, communications windchimes]
 +
  if(item_amount(trash) > 0)
 +
      sell(to_coinmaster(trash.buyer), item_amount(trash), trash);
 +
</syntaxhighlight>
 +
}}|
  
Should we add the correct examples? Or are the fixes clear enough?
+
see_also={{SeeAlso|visit|is_accessible|buys_item|sells_item}}|
--[[User:Slyz|Slyz]] 08:36, 18 April 2010 (UTC)
+
}}
  
If anything particularly complicated shows, we can give both. But so far, if you can't follow as written, I'm not sure you ever will. (That's the hypothetical "you," not the specific "hey Slyz what's wrong with you, you"). --[[User:StDoodle|StDoodle (#1059825)]] 23:35, 19 April 2010 (UTC)
+
[[Category:Item Management]]
 
 
 
 
 
 
{{CodeSample|description=The following code results in an error.
 
|code=<syntaxhighlight>
 
void my_function( string myvar = "value" )
 
{
 
  /* Do something */
 
}
 
</syntaxhighlight>}}
 
Error message: <blockquote>Cannot initialize parameter myvar (filename.ash, line X)</blockquote>
 
I'd like to add this to the article myself, but I'm not sure how to explain its exact nature. Would this message appear only in a situation like the above code? --[[User:PhilmASTErpLus|PhilmASTErpLus]] 09:30, 28 July 2010 (UTC)
 
: Looks like a conflict of functionality -- the two ways to initialize a variable are '''string myvar''' and '''string myvar = "value"'''. The only proper way to define a parameter is the former. So basically you're defining a parameter, which then gets initialized with a value. This would lead to all sorts of problems, so the parser catches this exception and throws an error. I'm not really sure why anyone would want to do this, but I guess you can add it? (fun fact: the value that you set the parameter to doesn't actually have to match the datatype for this error to appear) --[[User:Heeheehee|Heeheehee]] 16:47, 28 July 2010 (UTC)
 
 
 
I'm guessing he tried it for the same reason I did; in some languages, that's how you provide a default value for a parameter. It's usually functionally equivalent to having two different versions of my_function() defined, one which accepts a single string, and one which accepts no parameters, and calls the other with the default value. Usually it isn't a big deal to do things one way or the other, but the method given above can actually be much simpler if you get into a large number of overloaded versions of a single function. --[[User:StDoodle|StDoodle (#1059825)]] 18:30, 28 July 2010 (UTC)
 
: In that case, would this be a reasonable low-priority feature request? --[[User:Heeheehee|Heeheehee]] 18:44, 28 July 2010 (UTC)
 
 
 
That's up to the devs, but I have a feeling it would be a non-trivial change to get a trivial benefit, and therefore ignored. Unless someone has a good argument for a situation in which it would make a huge difference. --[[User:StDoodle|StDoodle (#1059825)]] 21:08, 28 July 2010 (UTC)
 
 
 
 
 
{{CodeSample|description=Hardly worth suggesting. The KoLmafia method works just fine:
 
|code=<syntaxhighlight>
 
void my_function()
 
{
 
  my_function("value");
 
}
 
</syntaxhighlight>}}
 
--[[User:Bale|Bale]] 04:31, 29 July 2010 (UTC)
 
:Yeah, when I posted that code, I wasn't thinking about requesting for a default parameter feature. All I'd like to know is whether there is a general case that will trigger this particular error message; for example, I would have expected this instead of "expected ) but got =" message when I tried assignment in the conditional for the <code>if</code> and <code>while</code> statements. --[[User:PhilmASTErpLus|PhilmASTErpLus]] 13:17, 29 July 2010 (UTC)
 

Revision as of 04:12, 21 July 2011

Function Syntax

boolean to_coinmaster(string store )

  • store is hopefully the name of a coinmaster

Returns the coinmaster that matches the string store. This is useful so that the coinmaster datatype can be used by other functions. If store does not match the name of any coinmaster, then the function returns $coinmaster[none]. This works on partial matches so that if store is "dime", this function will return $coinmaster[Dimemaster].

Code Sample

This sells off all the Island War vendor trash to the appropriate coinmasters for quarters and dimes.

foreach trash in $items[red class ring, blue class ring, white class ring, PADL Phone, 
 pink clay bead, purple clay bead, green clay bead, communications windchimes]
   if(item_amount(trash) > 0)
      sell(to_coinmaster(trash.buyer), item_amount(trash), trash);

See Also

visit() | is_accessible() | buys_item() | sells_item()