Talk:KoLmafia Guide: Running ASH Scripts

From Kolmafia
Revision as of 05:23, 19 May 2010 by imported>Bale
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigation Jump to search

Scary!?

SinginSally, I notice you just added a whole script to the bottom of the page. Aren't you afraid that the huge wall of text will scare away a newbie? This isn't the scripting lesson after all so they aren't looking for that. I worry that you're discovering the coolness of scripts that newbies might not be ready for. --Bale 23:04, 11 May 2010 (UTC)

  • I made the script a little smaller with some creative formatting. Though I'm very tempted to make the code nicer also... I can't believe it actually hits the server separately for every single tattoo instead of only reading in visit_url("account_tattoos.php") once and saving the result! That's abyssal! It would also be good to use a foreach to skip the tattoo 13, instead of needing a placeholder. Of course you're displaying someone else's script so it might confuse them if I made this version better and the version on the forum worked differently. Perhaps I should complain there. --Bale 05:23, 19 May 2010 (UTC)

Also!

Please be careful about removing, and telling others to remove, "notify." The beauty of this command is that it's a "safe" way to send a kmail to the script author (the message is automatically formatted by KoLmafia, so there's no way for a script author to use "notify" to steal your stuff / meat). Many scripts require quite a bit of maintanence to keep them running with changes to KoL & KoLmafia, and the authors aren't likely to put in the work if it seems as though no one is using their script.

tl;dr Feel free to tell users to edit out other kmail functions, but please don't encourage people to remove "notify." --StDoodle (#1059825) 01:04, 12 May 2010 (UTC)